feat: add route and menu support for axis tick properties#12133
Merged
Conversation
kgryte
added
Feature
kgryte
reviewed
May 14, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
May 15, 2026
kgryte
reviewed
May 15, 2026
kgryte
reviewed
May 15, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
May 15, 2026
kgryte
reviewed
May 15, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
May 15, 2026
| var body = require( './../../../../middleware/body' ); | ||
| var ok = require( './../../../../middleware/ok' ); | ||
| var onError = require( './../../../../middleware/error' ); | ||
| var transform = require( './../../transforms.js' ).toTickCount; |
Member
There was a problem hiding this comment.
Agreed that tickCount is a bit special in its handling, so having a dedicated transform makes sense.
kgryte
reviewed
May 15, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
May 15, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
May 15, 2026
kgryte
reviewed
May 15, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
May 15, 2026
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
LGTM. That demo is quite nice. I think we are building something really unique here.
kgryte
reviewed
May 15, 2026
kgryte
reviewed
May 15, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
May 15, 2026
Member
|
As the CI failure is expected, I'll go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves None
Description
This pull request:
Screen.Recording.2026-05-15.at.2.11.59.AM.mov
Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
@stdlib-js/reviewers